Skip to content

Conversation

@sahil-ansari01
Copy link

…o that the nets appear with that color via the rats nest in the pcb-viewer #796

…o that the nets appear with that color via the rats nest in the pcb-viewer #796
Copy link
Contributor

@Anshgrover23 Anshgrover23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts.

outer_diameter: distance.optional(),
from_layer: z.string(),
to_layer: z.string(),
// Allow color to be specified on vias for type uniformity, though it may be ignored downstream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unnecessary comments.

trace_length: z.number().optional(),
rats_nest_color: z.string().optional(),
route: z.array(pcb_trace_route_point),
// Non-empty route to avoid undefined at index 0 in consumers/tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well.

}),
),
),
edges: z
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change, as it is only related to adding color property only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants